Remove usage of actions-rs actions #7422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They appear to be unmaintained at this point: actions-rs/toolchain#216 Also for most of these we can simply use the Rust that comes with the GHA image
reaperhulk
reviewed
Jul 15, 2022
| @@ -216,12 +213,9 @@ jobs: | |||
| with: | |||
| python-version: ${{ matrix.PYTHON.VERSION }} | |||
| architecture: ${{ matrix.WINDOWS.ARCH }} | |||
| - uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af | |||
| - uses: dtolnay/rust-toolchain@3d5c338b548e8aff8b55d96390e28fa86945e1b2 | |||
There was a problem hiding this comment.
Why do we need this for the windows wheel builder but not the windows CI job now?
There was a problem hiding this comment.
I left it in the wheel builders to ensure releases are always built on the latest stable rust, in case the images are lagging behind. Being one release behind isn't a problem for CI.
reaperhulk
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They appear to be unmaintained at this point: actions-rs/toolchain#216
Also for most of these we can simply use the Rust that comes with the GHA image